Skip to content

Small exception improvements #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Small exception improvements #704

wants to merge 2 commits into from

Conversation

Blaubeeree
Copy link

Changes

Made it simpler to catch all claim-related Exceptions.

  • add claimName to InvalidClaimException (which was already present in all sub-classes)
  • make TokenExpiredException extend IncorrectClaimException

Testing

  • This change adds test coverage
  • This change has been tested on the latest version of Java or why not

Checklist

@Blaubeeree Blaubeeree requested a review from a team as a code owner January 16, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@vksaran843 vksaran843 vksaran843 approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Blaubeeree @vksaran843